Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-248533: Fix X509Type as a enum #1576

Merged
merged 1 commit into from
May 10, 2024
Merged

CLOUDP-248533: Fix X509Type as a enum #1576

merged 1 commit into from
May 10, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented May 9, 2024

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg added the cloud-tests Run expensive Cloud Tests: Integration & E2E label May 9, 2024
@josvazg josvazg marked this pull request as draft May 9, 2024 14:41
@josvazg josvazg force-pushed the CLOUDP-248533/fix-x509type-enum branch from f5702f9 to 2a18c92 Compare May 9, 2024 14:45
@josvazg
Fix X509Type as a enum
0aa2d9f 
Signed-off-by: jose.vazquez <[email protected]>
@josvazg josvazg force-pushed the CLOUDP-248533/fix-x509type-enum branch from 2a18c92 to 0aa2d9f Compare May 9, 2024 14:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/0aa2d9f4f487bd47ba930348d684ae26344ba4e9

@josvazg
Copy link
Collaborator Author

josvazg commented May 10, 2024 •
edited
Loading

Bad news here, I thought this change introduced some errors that I had to find and fix. But it is worse actually, introduces new flakiness. It either creates such flakiness somehow or increases the likelihood of an issue that was already there.

@josvazg josvazg removed the cloud-tests Run expensive Cloud Tests: Integration & E2E label May 10, 2024
@josvazg josvazg marked this pull request as ready for review May 10, 2024 08:40
@josvazg
Copy link
Collaborator Author

josvazg commented May 10, 2024

Today flakiness might have gone away locally and in the CI, not sure how to proceed. Will wait for tests to complete.

@josvazg josvazg requested review from s-urbaniak and helderjs May 10, 2024 09:51
@josvazg josvazg requested a review from roothorp May 10, 2024 09:52
@josvazg
Copy link
Collaborator Author

josvazg commented May 10, 2024

Only serverless failed, which is a well known flaky from before so, maybe we can merge this already.

@josvazg josvazg changed the title Fix X509Type as a enum CLOUDP-248533: Fix X509Type as a enum May 10, 2024
@josvazg
Copy link
Collaborator Author

josvazg commented May 10, 2024

related to CLOUDP-248533

@josvazg josvazg merged commit fbbe7e0 into main May 10, 2024
101 of 107 checks passed
@roothorp roothorp deleted the CLOUDP-248533/fix-x509type-enum branch September 26, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helderjs helderjs helderjs approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josvazg @helderjs