CLOUDP-239182: Ensure teams are always cleaned up

[igor-karpukhin]

All Submissions:

Ensure teams are always cleaned up

• Have you signed our CLA?
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
• Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

[github-actions]

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/fc82d01d07de15b8ab64c3c8637fdec74fcda4d8

[s-urbaniak]

Looks great, just a couple of comments 👍

[igor-karpukhin]

@helderjs please take a look when you have time. I moved changed the logic as we agreed

[helderjs]

LGTM, just a last comment

[s-urbaniak]

LGTM given @helderjs's comments are addressed 👍

[s-urbaniak]

One last nit and a missing unit test.

[s-urbaniak]

@igor-karpukhin This contribution adds a unit test for updateTeamState, however the handleDeletion function in AtlasProjectReconciler has been changed here but is not tested at all. Please add a unit test covering the finalizer case which invokes the added syncAssignedTeams handling.

[igor-karpukhin]

@igor-karpukhin This contribution adds a unit test for updateTeamState, however the handleDeletion function in AtlasProjectReconciler has been changed here but is not tested at all. Please add a unit test covering the finalizer case which invokes the added syncAssignedTeams handling.

The new unit-test added for testing the team removal logic when an AtlasProject is removed

[s-urbaniak]

@igor-karpukhin please assert the returned result from handleDeletion. Looking at the coverage profile, the zero value is returned and not an explicit OK().