Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-208446: Rename Cloud Provider Access to Cloud Provider Integration #1230

Merged
merged 2 commits into from
Dec 4, 2023
Merged

CLOUDP-208446: Rename Cloud Provider Access to Cloud Provider Integration #1230

merged 2 commits into from
Dec 4, 2023

Conversation

helderjs
Copy link
Collaborator

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@helderjs helderjs added the cloud-tests Run expensive Cloud Tests: Integration & E2E label Nov 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/d3ee8aac9ba1cc0454cfbba269b16798cebf35b6

@helderjs helderjs force-pushed the CLOUDP-208446-rename-cpa branch from 5431e2f to de22bc8 Compare November 13, 2023 16:08
@helderjs helderjs marked this pull request as ready for review November 13, 2023 19:22
josvazg
josvazg reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I wonder if we missed some rebasing?

@josvazg
Copy link
Collaborator

josvazg commented Nov 17, 2023

Do not see changes from my last review, am I missing something?

@helderjs helderjs force-pushed the CLOUDP-208446-rename-cpa branch from c5d8c92 to 03baa41 Compare November 29, 2023 16:03
josvazg
josvazg approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-urbaniak
Copy link
Collaborator

@helderjs correct me if i'm wrong but where is the code that signals the user to use the new type as a status on the operator?

@helderjs
Copy link
Collaborator Author

@helderjs correct me if i'm wrong but where is the code that signals the user to use the new type as a status on the operator?

@s-urbaniak ptal and let me know if it's all good now

s-urbaniak
s-urbaniak requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one open question regarding package imports, else LGTM

s-urbaniak
s-urbaniak approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed OOB: the remaining questions will be tracked as jira tickets.

@helderjs helderjs merged commit fc7f6b8 into main Dec 4, 2023
43 checks passed
@helderjs helderjs deleted the CLOUDP-208446-rename-cpa branch December 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
cloud-tests Run expensive Cloud Tests: Integration & E2E
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helderjs @josvazg @s-urbaniak