Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-196968: Put go context within workflow.Context #1152

Merged
merged 1 commit into from
Oct 11, 2023
Merged

CLOUDP-196968: Put go context within workflow.Context #1152

merged 1 commit into from
Oct 11, 2023

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Oct 3, 2023 •
edited
Loading

This change looks bug, it is actually the effect of just 3 changes:

  1. Add a Context context.Context field into the workflow.Context struct.
  2. Use that new field to embed the Go context that used to be around inside the workflow.Context.
  3. Collapse the argument pair of a Go context and a MongoDB Client into a single workflow.Context, which now contains both.

There are a few typo fixes as well.

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@josvazg josvazg changed the title Put go context within workflow.Context CLOUDP-196968: Put go context within workflow.Context Oct 3, 2023
@josvazg josvazg force-pushed the CLOUDP-196968/context-in-wfctx branch 2 times, most recently from ec000c6 to 79bebe6 Compare October 3, 2023 10:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/7d854e8012da3a48f84cbc2473c711b8c50dad1b

@josvazg josvazg force-pushed the CLOUDP-196968/context-in-wfctx branch from 79bebe6 to 1069df1 Compare October 10, 2023 12:27
@josvazg josvazg force-pushed the CLOUDP-196968/context-in-wfctx branch from 1069df1 to 7d854e8 Compare October 10, 2023 15:46
@josvazg josvazg merged commit 3fc578b into main Oct 11, 2023
41 checks passed
@josvazg josvazg deleted the CLOUDP-196968/context-in-wfctx branch October 11, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@helderjs helderjs helderjs approved these changes

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josvazg @helderjs @igor-karpukhin