Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-186806: Move encryption at rest credentials to secrets #1045

Merged
merged 7 commits into from
Aug 2, 2023
Merged

CLOUDP-186806: Move encryption at rest credentials to secrets #1045

merged 7 commits into from
Aug 2, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Move encryption at rest credentials to secrets

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/1188d3e50062709ed4c28da5ff29005447b04574

@igor-karpukhin igor-karpukhin marked this pull request as ready for review July 31, 2023 17:17
josvazg
josvazg approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nitpick, I would replace fillStructFields by simple explicit struct assignments, I really feel it will be less code and more readable.

@josvazg josvazg self-requested a review August 2, 2023 07:02
josvazg
josvazg reviewed Aug 2, 2023
View reviewed changes
pkg/controller/atlasproject/encryption_at_rest_test.go
}

err := readEncryptionAtRestSecrets(kk, service, encRest, "test")
assert.NotNil(t, err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check for a particular error or text within the error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but in this case it is just to check that all fields were read correctly and there are no problems with a secret data

josvazg
josvazg approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick question

@igor-karpukhin igor-karpukhin merged commit 1768b4b into main Aug 2, 2023
@igor-karpukhin igor-karpukhin deleted the CLOUDP-186806/enc-rest-creds branch August 2, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-karpukhin @helderjs @josvazg