fixing the find or delete serde inconsistency #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found an inconsistency in the way mongo documents are deserialized when using
serde(with)
andfind_one_and_delete
. My fix might nor be ideal because it breaksThe tests no longer return
Err(_)
but justOk(None)
. I am not sure how I can assert that Field is present but can be null, when deserializingOption<T>
and could not find anything either.I added a tests to verify my changes fix the issue (see changes)