RUST-956 Include service_id in relevant events
#469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
force-pushed
the
RUST-956/serviceid-event
branch
from
173b063 to
3797331
Compare
patrickfreed
approved these changes
Sep 22, 2021
abr-egn
force-pushed
the
RUST-956/serviceid-event
branch
from
3797331 to
3709615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-956
Some events need the
service_idof the backend behind the load balancer; this adds those. For theCommand*events, this would have fit better in theConnectionInfostruct, but unfortunately that's not markednon_exhaustiveso that would be a breaking change :(Whichever of this or #465 is merged later will need to include the (trivial) event matching code for this field.