RUST-1982 Fix aggregate with_type with explicit session #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
approved these changes
Jun 27, 2024
Happily, it turned out just being explicit that 'self' doesn't actually cross the await point fixed this without the need for a bound. I guess the newer compiler version is smart enough to notice that itself. |
qm3ster
pushed a commit
to qm3ster/mongo-rust-driver
that referenced
this pull request
Jun 27, 2024
abr-egn
added a commit
to abr-egn/mongo-rust-driver
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1982
We accidentally overspecialized the impls here, meaning both
aggregate(..).session(..).with_type::<T>()andaggregate(..).with_type::<T>().session(..)would fail to compile for slightly different reasons.