RUST-1845 Support search index type field #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/spec/index_management.rs
Outdated
| .create_search_index( | ||
| SearchIndexModel::builder() | ||
| .name(String::from("test-search-index-case7-vector")) | ||
| .index_type(SearchIndexType::VectorSearch) |
There was a problem hiding this comment.
The definition for this test doesn't include the type field in the index model -- this probably shouldn't be passing written as-is? I think the create_search_index call here is equivalent to the last one in the test above
There was a problem hiding this comment.
As it turns out, the test was failing (i.e. the index creation was succeeding), but when I kicked off the evergreen run I accidentally left in a restriction that filtered out the test entirely. I've fixed the test and also updated the evergreen config to include the test-level breakdown which would have made that more obvious. New passing run is here :)
isabelatkinson
approved these changes
Jun 27, 2024
qm3ster
pushed a commit
to qm3ster/mongo-rust-driver
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1845
Pretty straightforward. The prose test run isn't patchable so here's the passing run.