Sync CRUD unified tests #1543
Merged
Sync CRUD unified tests #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nhachicha
commented
Oct 29, 2024
•
nhachicha
commented
- Removed all client bulkWrite tests until @stIncMale finishes the implementation
- Added some skips in driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedCrudTest.java
- Fix checkstyle
jyemin
requested changes
Oct 30, 2024
nhachicha
requested review from
jyemin
and removed request for
jyemin and
stIncMale
jyemin
requested changes
Oct 30, 2024
| assumeFalse(testDescription.toLowerCase().contains("replaceone with sort option"), "Skipping until JAVA-5622 is implemented"); | ||
| assumeFalse(testDescription.equals("BulkWrite with string comment"), "Skipping until we decide " | ||
| + "whether to update the spec or test https://mongodb.slack.com/archives/C72LB5RPV/p1730225657999979"); | ||
| assumeFalse(testDescription.equals("BulkWrite with document comment"), "Skipping until we decide " |
There was a problem hiding this comment.
Let's only include links that are accessible to the public. Slack doesn't fit the bill.
| @@ -122,7 +122,6 @@ | |||
| "expectEvents": [ | |||
| { | |||
| "client": "client0", | |||
| "note": "Events split due to : JAVA-4537 ", | |||
There was a problem hiding this comment.
Since we had previously decided to change this test, let's not reverse this decision until we have a better alternative. I'd prefer to revert the change to this file and leave it as is.
jyemin
requested changes
Oct 30, 2024
| @@ -43,6 +43,22 @@ public static void doSkips(final String fileDescription, final String testDescri | |||
| assumeFalse(testDescription.equals("Aggregate with $out includes read preference for 5.0+ server")); | |||
| assumeFalse(testDescription.equals("Database-level aggregate with $out includes read preference for 5.0+ server")); | |||
| } | |||
| if (fileDescription.equals("updateOne-sort")) { | |||
| assumeFalse(testDescription.equals("UpdateOne with sort option")); | |||
There was a problem hiding this comment.
Let's add a second param for each of these, like "Skipped until implementation of JAVA-XXXX", where XXXX is the issue number for adding sort to update/replace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.