Use JCA provider for implementation of PBKDF2 #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the driver implemented the PBKDF2 (Password-based-Key-Derivative-Function) function itself. With this change it instead looks up an implementation of either PBKDF2WithHmacSHA1 or PBKDF2WithHmacSHA256 from the JCA provider via SecretKeyFactory#getInstance. JAVA-5507
rozza
approved these changes
Jul 17, 2024
vbabanin
approved these changes
Jul 18, 2024
| throw new SaslException(format("Algorithm for '%s' could not be found.", hmacAlgorithm), e); | ||
| } catch (InvalidKeyException e) { | ||
| throw new SaslException(format("Invalid key for %s", hmacAlgorithm), e); | ||
| throw new SaslException(format("Algorithm for '%s' could not be found.", pbeAlgorithm), e); |
There was a problem hiding this comment.
[nit] This String is repeated in the code. It could be a candidate for a constant.
Oh, good memory! I checked and found that PBKDF2WithHmacSHA1 is supported back to Java 6 but PBKDF2WithHmacSHA256 came in Java 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the driver implemented the PBKDF2 (Password-based-Key-Derivative-Function) function itself. With this change it instead looks up an implementation of either PBKDF2WithHmacSHA1 or PBKDF2WithHmacSHA256 from the JCA provider via SecretKeyFactory#getInstance.
JAVA-5507