Optimize GridFS throughput by removing redundant byte array cloning. #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
requested changes
Jun 3, 2024
driver-sync/src/main/com/mongodb/client/gridfs/GridFSDownloadStreamImpl.java
Outdated
Show resolved
Hide resolved
driver-sync/src/main/com/mongodb/client/gridfs/GridFSDownloadStreamImpl.java
Outdated
Show resolved
Hide resolved
rozza
reviewed
Jun 4, 2024
driver-sync/src/main/com/mongodb/client/gridfs/GridFSDownloadStreamImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ross Lawley <[email protected]> Co-authored-by: Jeff Yemin <[email protected]>
jyemin
approved these changes
Jun 4, 2024
rozza
approved these changes
Jun 5, 2024
|
LGTM - great find and fix, quite a subtle change / fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces performance improvement in the GridFS implementation of the sync Java driver, specifically targeting the
GridFSDownloadStreamandGridFSUploadStreamclasses. It was identified that byte arrays are cloned twice internally via theBinaryclass, which impacts throughput.Key Changes:
Modified
GridFSDownloadStreamandGridFSUploadStreamto useBsonDocumentinstead ofDocument.TheBsonDocumentimplementation avoids the unnecessary copying in theBsonBinaryclass, thus enhancing performance.Performance Improvements:
GridFS Download:
Stable Region Mean on main branch = 769.21 MBps
Perf result mean = 1030.63 MBps
Improvement: Approximately 34.02% increase in throughput
GridFS Upload:
Stable Region Mean on main branch = 450.62 MBps
Perf result mean = 515.84 MBps
Improvement: Approximately 14.48% increase in throughput
Additional Information:
For further details and results of performance tests executed on this patch, please refer to the performance test results.
JAVA-5485