-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EF-165: Support for EF Core 9 - CI scripts #180
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT but a couple of non-blocking questions.
Thanks!
<ItemGroup Condition=" '$(Configuration)' == 'Release' Or '$(Configuration)' == 'Debug' "> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.12" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup Condition=" '$(Configuration)' == 'Release EF9' Or '$(Configuration)' == 'Debug EF9' "> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.1" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has his file changed?
|
||
export DRIVERS_TOOLS="$(pwd)/../drivers-tools" | ||
export DOTNET_SDK_PATH="$(pwd)/../.dotnet" | ||
|
||
if [ "Windows_NT" = "$OS" ]; then # Magic variable in cygwin | ||
# Python has cygwin path problems on Windows. Detect prospective mongo-orchestration home directory | ||
export DRIVERS_TOOLS=$(cygpath -m $DRIVERS_TOOLS) | ||
else | ||
# non windows OSs don't have dotnet in the PATH | ||
export PATH=$PATH:/usr/share/dotnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?
I'm going to ship a 8.x release tomorrow (Tuesday) - we can merge this in after that? |
No description provided.