Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF-165: Support for EF Core 9 - CI scripts #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner January 30, 2025 04:45
@sanych-sun sanych-sun requested review from adelinowona and damieng and removed request for a team and adelinowona January 30, 2025 04:45
@sanych-sun sanych-sun changed the title Add build scripts EF-165: Support for EF Core 9 - CI scripts Jan 30, 2025
Copy link
Member

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but a couple of non-blocking questions.

Thanks!

<ItemGroup Condition=" '$(Configuration)' == 'Release' Or '$(Configuration)' == 'Debug' ">
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.12" />
</ItemGroup>

<ItemGroup Condition=" '$(Configuration)' == 'Release EF9' Or '$(Configuration)' == 'Debug EF9' ">
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.1" />
</ItemGroup>

<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has his file changed?


export DRIVERS_TOOLS="$(pwd)/../drivers-tools"
export DOTNET_SDK_PATH="$(pwd)/../.dotnet"

if [ "Windows_NT" = "$OS" ]; then # Magic variable in cygwin
# Python has cygwin path problems on Windows. Detect prospective mongo-orchestration home directory
export DRIVERS_TOOLS=$(cygpath -m $DRIVERS_TOOLS)
else
# non windows OSs don't have dotnet in the PATH
export PATH=$PATH:/usr/share/dotnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

@damieng
Copy link
Member

damieng commented Feb 3, 2025

I'm going to ship a 8.x release tomorrow (Tuesday) - we can merge this in after that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants