Address compiler warnings #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
force-pushed
the
address-compiler-warnings
branch
from
f08a33b to
c60ff55
Compare
damieng
requested review from
janiavdv and
BorisDog
and removed request for
a team and
janiavdv
BorisDog
reviewed
Jun 20, 2024
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> | ||
| <NoWarn>EF1001,CS8602,CS8618</NoWarn> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Does it makes sense to migrate those settings (or a subset) to tests/Directory.Build.props ?
There was a problem hiding this comment.
I don't think it's worth it yet. There won't likely be more test projects or any new stuff any time soon.
There was a problem hiding this comment.
So we have Directory.Build.props already, seems like a natural place for such settings.
BorisDog
approved these changes
Jun 25, 2024
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> | ||
| <NoWarn>EF1001,CS8602,CS8618</NoWarn> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
So we have Directory.Build.props already, seems like a natural place for such settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just around null annotations but also a few unused properties etc.
Solution now compiles 100% clean with Roslyn, no warnings.