Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDRIVER-5497 implement downstream RPM spec check #1551

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

rcsanchez97
Copy link
Collaborator

This change implements a check whereby if the RPM spec file we are shipping in the C driver repository differs from the downstream RPM spec file (e.g., because downstream has updated and we have not yet synced it to obtain that update), then the rpm-package-build task will fail. This is implemented so that it will only run on waterfall builds (so that patch builds are not unnecessarily cluttered by a most likely unrelated failure of this task).

Patch build: https://spruce.mongodb.com/task/mongo_c_driver_packaging_rpm_package_build_patch_bef6e2d37436fd465f165d7062af9fe2262d6738_65e76bd77742aeab743dd2c9_24_03_05_19_00_42/logs?execution=0

[2024/03/05 14:02:04.386] Running command 'shell.exec' (step 1 of 4).
[2024/03/05 14:02:04.391] This is a patch build...skipping RPM spec check
[2024/03/05 14:02:04.391] Finished command 'shell.exec' (step 1 of 4) in 4.205077ms.

Simulated waterfall build (failure): https://spruce.mongodb.com/task/mongo_c_driver_packaging_rpm_package_build_patch_bef6e2d37436fd465f165d7062af9fe2262d6738_65e76a571e2d17ab5ad0ee45_24_03_05_18_54_19/logs?execution=0

[2024/03/05 13:58:53.494] Running command 'shell.exec' (step 1 of 4).
[2024/03/05 13:58:53.688] Files .evergreen/etc/mongo-c-driver.spec and /data/mci/770212188af98933ef70bdd5e63e2642/tmp/mongo-c-driver.sQAlkiZ7.spec differ
[2024/03/05 13:58:53.690] Synchronize RPM spec from downstream to fix this failure.
[2024/03/05 13:58:53.690] Command 'shell.exec' (step 1 of 4) failed: shell script encountered problem: exit code 1.

Simulated waterfall build (success, produces no output): https://spruce.mongodb.com/task/mongo_c_driver_packaging_rpm_package_build_patch_bef6e2d37436fd465f165d7062af9fe2262d6738_65e76a2ae3c331b0aa3b7297_24_03_05_18_53_34/logs?execution=0

[2024/03/05 13:57:01.710] Running command 'shell.exec' (step 1 of 4).
[2024/03/05 13:57:01.900] Finished command 'shell.exec' (step 1 of 4) in 189.687348ms.

I will also cherry-pick this to r1.26 after merging.

@rcsanchez97 rcsanchez97 requested a review from kevinAlbs March 5, 2024 19:10
.evergreen/scripts/check_rpm_spec.sh Outdated Show resolved Hide resolved
Co-authored-by: Kevin Albertson <[email protected]>
@rcsanchez97 rcsanchez97 merged commit f6547a3 into mongodb:master Mar 5, 2024
1 check was pending
@rcsanchez97 rcsanchez97 deleted the cdriver-5497 branch March 5, 2024 22:04
rcsanchez97 added a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants