fix(NODE-6109): allow building from source on latest Node.js 20.x #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested review from
durran,
baileympearson,
dariakp and
addaleax
as code owners
addaleax
approved these changes
Apr 22, 2024
baileympearson
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUTto fix issue node-addon-api addons broken by default on Node.js 20.12+ nodejs/node#52229Is there new documentation needed for these changes?
No
What is the motivation for this change?
Release Highlight
Add
NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUTto fix building on Node.js 20.xNode.js v20.12.0 introduced a change that prevented compiling the existing source without defining the above macro.
Double check the following
npm run check:eslintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript