Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5516): allow undefined values for optional Uint8Arrays arguments #683

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 8, 2023

this PR relaxes the assertions in Node's C++ bindings to allow undefined values for Uint8Array options. The logic was accidentally made a bit too strict in #682, which broke Node's driver CI.

I only applied the fix to options touched in #682. Additionally, this was only relevant to options (not function arguments). So for example, the following is still invalid (because the first argument to makeDecryptionContext must be provided and was never optional): mongocrypt.makeDecryptionContext(undefined).

@durran durran self-assigned this Aug 9, 2023
@durran durran added the js-team-review Needs final review from Node.js team label Aug 9, 2023
@durran durran merged commit 8cd5850 into master Aug 9, 2023
@durran durran deleted the NODE-5516 branch August 9, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js-team-review Needs final review from Node.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants