Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for FreeBSD #625

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Fix build for FreeBSD #625

merged 4 commits into from
Apr 28, 2023

Conversation

kkloberdanz
Copy link
Contributor

@kkloberdanz kkloberdanz commented Apr 21, 2023 •
edited
Loading

CDRIVER-4465

  • Missing math library for trig functions
  • Patch IntelDFP to correctly identify x86_64

@kkloberdanz
Fix build for FreeBSD
612a562 
* Missing math library for trig functions
* Patch IntelDFP to correctly identify x86_64
@kkloberdanz kkloberdanz force-pushed the kyle/fix-build-for-freebsd branch from b795925 to 612a562 Compare April 24, 2023 16:10
@kkloberdanz kkloberdanz marked this pull request as ready for review April 24, 2023 20:54
kevinAlbs
kevinAlbs approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment fix.

cmake/IntelDFP.cmake Show resolved Hide resolved
vector-of-bool
vector-of-bool approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a recommended build simplification

CMakeLists.txt Outdated Show resolved Hide resolved
@kkloberdanz kkloberdanz merged commit 5c53478 into mongodb:master Apr 28, 2023
@kkloberdanz kkloberdanz deleted the kyle/fix-build-for-freebsd branch April 28, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vector-of-bool vector-of-bool vector-of-bool approved these changes

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkloberdanz @kevinAlbs @vector-of-bool