-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4578: Add drag and drop / sorting functionality to charts #2735
Draft
tsck
wants to merge
20
commits into
main
Choose a base branch
from
LG-4578/charts-drag-drop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +1.76 kB (+0.13%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds the
@lg-charts/drag-provider
package to provide draggable functionality forChart
andChartCard
components.🎟 Jira ticket: LG-4578
Technical Details
External Tooling
@dnd-kit
- Used to provide the underlying drag functionality.Exposed
<DragProvider>
Chart
orChartCard
with adragId
prop within the provider.onDragEnd: ({ over: string; active: string }) => void
active
-dragId
of the drag component being dragged.over
-dragId
of the drag component the active component is over ondragEnd
.Internal
<ChildStateUpdateProvider>
<DragProvider>
and exposesupdateChildState()
to childrenupdateChildState(dragId: string, stateUpdate: Object)
<DragProvider>
, it creates a new component based on the child it receives and uses that as the “drag overlay” (component that visually moves while the mouse moves). If a child’s internal state controls a visual element (such as uncontrolled open/close), the provider naturally has no idea this occurs. This is an issue because it will render the handle incorrectly when the user attempts to drag it. This method allows for internal state updates to register upwards to correct for this issue.ChartCard
to propagate uncontrolled changes to the open/close state.Example
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changeset
and documented my changesFor new components
🧪 How to test changes