LG-4906: mobile responsive Drawer #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
tsck
reviewed
Feb 14, 2025
Comment on lines
28
to
38
| bottom: 0; | ||
| left: 0; | ||
| right: 0; | ||
| box-shadow: ${open && theme === Theme.Light | ||
| ? `0 -10px 10px -10px rgba(0, 0, 0, 0.3)` | ||
| : 'initial'}; |
There was a problem hiding this comment.
Is it necessary to override bottom, right, and box-shadow here? The styles appear to be the same as what's on the base style.
There was a problem hiding this comment.
box-shadow is different between the 2
I originally left the bottom/right in to ensure changes to base style don't impact the mobile styles but I guess it's not necessary. Dropped!
tsck
approved these changes
Feb 14, 2025
stephl3
force-pushed
the
steph/dr-mobile
branch
from
e8fbf47 to
9632add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Drawer🎟 Jira ticket: LG-4906
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes
Drawerlive exampleDrawerlive example