[LG-4657] Code improvements integration #2670
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * wip - updating panel styles * updated panel styles * trying to combine styles * move styles to styles file * updating panel types * added context * ts docs * update copy button styles in panel * organize code style file * update types * remove unused type * wip code tests * add language prop to context * more tests updates * remove some tests * delete windowChrome and CustomSelectMenuButton * fix onChangeError * remove comment * check if language is in option * add clipboard check * added back props i initially deleted * remove props from context * update tsdocs * rename func and update tsdocs * add todo tests * adding more tests * remove unused tests * fix errors * remove copyable false * add error test * update tests and tsdocs * clean up * testids * dont skip test * update padding * updating generate stories * fix story error * fix build error * clean up * readme updates * forgot to save * fix language type * lint * more tests * remove fireevent * fix dep errors * update lock file * lint * title fix * update test to use context * feedback * changeset * typos * rephrase * update test * lint
* wip * wip - updating panel styles * updated panel styles * trying to combine styles * move styles to styles file * updating panel types * added context * ts docs * update copy button styles in panel * organize code style file * update types * remove unused type * wip code tests * add language prop to context * more tests updates * remove some tests * delete windowChrome and CustomSelectMenuButton * fix onChangeError * remove comment * check if language is in option * add copyButtonAppearance prop * add clipboard check * remove copyable prop * copy button styles * added back props i initially deleted * remove props from context * update tsdocs * rename func and update tsdocs * add todo tests * adding more tests * remove unused tests * fix errors * remove copyable false * add error test * update tests and tsdocs * clean up * testids * dont skip test * update padding * updating generate stories * fix story error * fix build error * clean up * readme updates * forgot to save * fix language type * lint * more tests * remove fireevent * fix dep errors * update lock file * add generated stories * lint * title fix * remove unused code and add new styles for button * updates * lint * forgot to save * update test to use context * fix spelling * lint * remove comment * update test * feedback * changeset * typos * rephrase * update test * readme * update docs * clean up * lib changeset * fix story props * sandy feedback * fix build error * build and story updates * lock * update genereated stories * showPanel and story updates * add showCopyButtonWithoutPanel const * remove extra div * discriminated union for copyButtonAppearnce and panel * use getMobileMediaQuery in select * changeset * doc feedback * fix tooltip issue and be more specific with svg styles * update docs and remove tooltip styles
🦋 Changeset detectedLatest commit: 90e683b The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +691 B (+0.05%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
* wip * wip - updating panel styles * updated panel styles * trying to combine styles * move styles to styles file * updating panel types * added context * ts docs * update copy button styles in panel * organize code style file * update types * remove unused type * wip code tests * add language prop to context * more tests updates * remove some tests * delete windowChrome and CustomSelectMenuButton * fix onChangeError * remove comment * check if language is in option * add copyButtonAppearance prop * add clipboard check * remove copyable prop * copy button styles * wip adding isLoadingProp * add isLoading to context * disabled copy icon styles * isLoading tests * added back props i initially deleted * remove props from context * update tsdocs * rename func and update tsdocs * add todo tests * adding more tests * remove unused tests * fix languageswitcher example * fix errors * fix errors * remove copyable false * add error test * update tests and tsdocs * clean up * testids * dont skip test * update padding * updating generate stories * fix story error * fix build error * clean up * readme updates * forgot to save * fix language type * lint * more tests * remove fireevent * fix dep errors * update lock file * add generated stories * lint * title fix * remove unused code and add new styles for button * updates * lint * forgot to save * loading story * lint * some cleanup * update test to use context * fix spelling * remove comments * lint * remove comment * update test * feedback * changeset * typos * rephrase * update test * readme * update docs * clean up * lib changeset * add ticket * update docs * fix story props * sandy feedback * fix build error * build and story updates * lock * update genereated stories * showPanel and story updates * add showCopyButtonWithoutPanel const * remove extra div * discriminated union for copyButtonAppearnce and panel * use getMobileMediaQuery in select * changeset * doc feedback * fix tooltip issue and be more specific with svg styles * add isLoading check * fix disabled copy button styles * docs * remove dup copy button * fix readme
…code-improvements-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes