PHPORM-283 Add Schema::dropSearchIndex()
#3235
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jan 2, 2025
src/Schema/Blueprint.php
Outdated
| /** | ||
| * Drop an Atlas Search or Vector Search index | ||
| */ | ||
| public function dropSearchIndex(string $name = 'default'): static |
There was a problem hiding this comment.
I think it's sensible to require an explicit value for $name since this is a destructive operation. It'd be consistent with PHPLIB's existing API.
There was a problem hiding this comment.
I assumed that if you don't need to specify the name to create or use the default index, it must be the same for deletion. But as a precaution, it can be required. It's now modified.
There was a problem hiding this comment.
Requiring explicit values for potentially destructive operations is the same reason the CRUD spec mandates a filter parameter for deletes. More generally, this logic can apply to any write operation (we also wouldn't want to default to an empty filter for an updateMany()).
jmikola
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-283
Same helper for both "search" and "vector search" indexes.
Checklist