Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan #2471

Closed
wants to merge 2 commits into from
Closed

Add PHPStan #2471

wants to merge 2 commits into from

Conversation

divine
Copy link
Contributor

@divine divine commented Nov 27, 2022

Add PHPStan

Closes: #1930

Fixes will be added with another PR to keep everything simple as possible.

@divine divine requested a review from Smolevich November 27, 2022 19:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (af13eda) 90.57% compared to head (d503699) 90.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2471   +/-   ##
=========================================
  Coverage     90.57%   90.57%           
  Complexity      748      748           
=========================================
  Files            34       34           
  Lines          1783     1783           
=========================================
  Hits           1615     1615           
  Misses          168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jenssegers
jenssegers previously approved these changes Jan 16, 2023
ini-values: memory_limit=-1
- name: Install dependencies
run: composer install --no-interaction
- name: Run PHPStan Analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to mark as not required step

@GromNaN GromNaN added this to the 4.0.0 milestone Aug 30, 2023
@Treggats
Copy link
Contributor

Treggats commented Nov 2, 2023

@divine would you be ok with it if I continue'd your work with this PR?

@divine
Copy link
Contributor Author

divine commented Nov 2, 2023

@divine would you be ok with it if I continue'd your work with this PR?

Hello,

Of course you can continue to work on this. Honestly, it's quite old PR, at that time there were like 300 errors that needed to be fixed, not sure how much is work currently is needed.

Thanks!

@Treggats
Copy link
Contributor

Treggats commented Nov 3, 2023

@divine would you be ok with it if I continue'd your work with this PR?

Hello,

Of course you can continue to work on this. Honestly, it's quite old PR, at that time there were like 300 errors that needed to be fixed, not sure how much is work currently is needed.

Thanks!

The amount of work depends on the level. On level 5 there are around 64 issues and on level 9, which is the max, there are 384 errors.
But for now I've set it to level 2, with a baseline. So it would ignore certain errors. Makes it easier to ease in to fixing those.

@GromNaN
Copy link
Member

GromNaN commented Nov 22, 2023

Closing in favor of #2664

@GromNaN GromNaN closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use static analyzer
6 participants