-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPStan #2471
Add PHPStan #2471
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2471 +/- ##
=========================================
Coverage 90.57% 90.57%
Complexity 748 748
=========================================
Files 34 34
Lines 1783 1783
=========================================
Hits 1615 1615
Misses 168 168 ☔ View full report in Codecov by Sentry. |
ini-values: memory_limit=-1 | ||
- name: Install dependencies | ||
run: composer install --no-interaction | ||
- name: Run PHPStan Analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to mark as not required step
@divine would you be ok with it if I continue'd your work with this PR? |
Hello, Of course you can continue to work on this. Honestly, it's quite old PR, at that time there were like 300 errors that needed to be fixed, not sure how much is work currently is needed. Thanks! |
The amount of work depends on the level. On level 5 there are around 64 issues and on level 9, which is the max, there are 384 errors. |
Closing in favor of #2664 |
Add PHPStan
Closes: #1930
Fixes will be added with another PR to keep everything simple as possible.