Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] feat: backport support for cursor pagination #2362

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[3.9] feat: backport support for cursor pagination #2362

merged 1 commit into from
Mar 7, 2022

Conversation

divine
Copy link
Contributor

@divine divine commented Mar 7, 2022 •
edited
Loading

Backport #2358 to L9.

Fixes #2312

Co-Authored-By: Jeroen van de Weerd [email protected]

@divine @Jeroenwv
feat: backport support for cursor pagination
46b407c 
Backport #2358 to L9

Co-Authored-By: Jeroen van de Weerd <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #2362 (46b407c) into master (8d601b2) will decrease coverage by 0.11%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2362      +/-   ##
============================================
- Coverage     87.75%   87.63%   -0.12%     
- Complexity      671      676       +5     
============================================
  Files            31       31              
  Lines          1535     1545      +10     
============================================
+ Hits           1347     1354       +7     
- Misses          188      191       +3
Impacted Files Coverage Δ
src/Eloquent/Builder.php 85.07% <70.00%> (-2.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d601b2...46b407c. Read the comment docs.

@divine divine changed the title feat: backport support for cursor pagination [3.9] feat: backport support for cursor pagination Mar 7, 2022
@divine divine requested review from jenssegers and Smolevich March 7, 2022 17:52
@divine divine merged commit f4c448f into master Mar 7, 2022
@divine divine deleted the feat-cursor-pagination branch March 7, 2022 20:07
divine added a commit that referenced this pull request Jan 16, 2023
@divine
Squashed commit of the following:
db72c17 
commit 551ec9f
Author: Henrique Troiano <[email protected]>
Date:   Sun Jan 15 20:19:33 2023 -0300

    Add Geonear instructions to ReadMe. Closes #1878 (#2487)

    * create aggregate geonear instructions

    * create aggregate geonear instructions

    * create aggregate geonear instructions

    * create aggregate geonear instructions

    * create aggregate geonear instructions

    * chore: revert back readme changes

    * chore: minor readme change

    Co-authored-by: henriquetroiano <[email protected]>
    Co-authored-by: divine <[email protected]>

commit 317f702
Author: Hikmat <[email protected]>
Date:   Sun Jan 15 04:58:12 2023 -0800

    fix: whereBelongsTo (#2454)

    * override getQualifiedForeignKeyName() and add tests for whereBelongsTo

    * delete unneeded query() call

    * type hint for getQualifiedForeignKeyName()

    Co-authored-by: Hikmat Hasanov <[email protected]>

commit e5e9193
Author: Andreas Braun <[email protected]>
Date:   Sun Nov 27 19:32:25 2022 +0100

    Transaction support (#2465)

    * Add support for transactions

    Co-authored-by: klinson <[email protected]>
    Co-authored-by: levon80999 <[email protected]>

    * Start single-member replica set in CI

    Co-authored-by: levon80999 <[email protected]>

    * Add connection options for faster failures in tests

    The faster connection and server selection timeouts ensure we don't spend too much time waiting for the inevitable as we're expecting fast connections on CI systems

    Co-authored-by: levon80999 <[email protected]>

    * Apply readme code review suggestions

    * Simplify replica set creation in CI

    * Apply feedback from code review

    * Update naming of database env variable in tests

    * Use default argument for server selection (which defaults to primary)

    * Revert "Simplify replica set creation in CI"

    This partially reverts commit 203160e. The simplified call unfortunately breaks tests.

    * Pass connection instance to transactional closure

    This is consistent with the behaviour of the original ManagesTransactions concern.

    * Correctly re-throw exception when callback attempts have been exceeded.

    * Limit transaction lifetime to 5 seconds

    This ensures that hung transactions don't block any subsequent operations for an unnecessary period of time.

    * Add build step to print MongoDB server status

    * Update src/Concerns/ManagesTransactions.php

    Co-authored-by: Jeremy Mikola <[email protected]>

    Co-authored-by: klinson <[email protected]>
    Co-authored-by: levon80999 <[email protected]>
    Co-authored-by: Jeremy Mikola <[email protected]>

commit 0606fc0
Author: Andreas Braun <[email protected]>
Date:   Mon Nov 14 12:51:00 2022 +0100

    Use single connection using DSN for testing (#2462)

    * Always use connection string in tests

    * Document DSN configuration as preferred configuration method

    * Update wordings

    * Use matrix config instead of manually specifying builds

    * Apply StyleCI fixes

    * Add missing test for code coverage

commit 560e05e
Author: Andreas Braun <[email protected]>
Date:   Mon Nov 14 12:46:55 2022 +0100

    Chore: add types where safe (#2464)

    * Use direct method calls over call_user_func_array

    * Add return types where safely possible

    * Fix styleCI issues

commit dbde512
Author: Andreas Braun <[email protected]>
Date:   Thu Nov 10 13:55:56 2022 +0100

    Pass timeout in milliseconds (#2461)

commit 42e0100
Author: abofazl rasoli <[email protected]>
Date:   Fri Nov 4 16:18:52 2022 +0330

    chore: test firstOrCreate method for the model (#2399)

commit 61cc6ed
Author: Stas <[email protected]>
Date:   Thu Sep 1 16:20:31 2022 +0300

    Add info about new release 3.9.2 (#2440)

    * Add info about new release 3.9.2

    * chore: update changelog

    Co-authored-by: Divine <[email protected]>

commit 5bcc82e
Merge: 41a9c97 f670c5f
Author: Stas <[email protected]>
Date:   Thu Sep 1 12:58:26 2022 +0300

    Merge pull request #2420 from apeisa/fix/stringable-sort

    [3.9] Fix/stringable sort

commit 41a9c97
Merge: ad4422a c27924c
Author: Stas <[email protected]>
Date:   Thu Sep 1 12:55:15 2022 +0300

    Merge pull request #2438 from RosemaryOrchard/pr/2394

    [3.9] Respect Laravel 9's single word name mutators

commit c27924c
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 17:11:29 2022 +0100

    Add tests for the mutator

commit 55e80a2
Merge: 6b11977 9b3ffc2
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:35:46 2022 +0100

    Merge branch 'pr/2394' of github.com:RosemaryOrchard/laravel-mongodb into pr/2394

commit 6b11977
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:17:58 2022 +0100

    Fix formatting

    More CS-Fixer formatting, unrelated to the PR

    PSR2?!

commit 9b3ffc2
Merge: e5a8272 ad4422a
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:32:21 2022 +0100

    Merge branch 'jenssegers:master' into pr/2394

commit e5a8272
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:25:57 2022 +0100

    PSR2?!

commit 79fad0e
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:22:46 2022 +0100

    More CS-Fixer formatting, unrelated to the PR

commit ce693a8
Author: Rosemary Orchard <[email protected]>
Date:   Thu Aug 25 14:17:58 2022 +0100

    Fix formatting

commit f670c5f
Author: Antti Peisa <[email protected]>
Date:   Mon Jul 25 13:59:05 2022 +0300

    Update tests/QueryTest.php

    Co-authored-by: Divine <[email protected]>

commit f7895bc
Author: Antti Peisa <[email protected]>
Date:   Mon Jul 25 13:58:59 2022 +0300

    Update tests/QueryTest.php

    Co-authored-by: Divine <[email protected]>

commit 3a87b28
Author: Antti Peisa <[email protected]>
Date:   Sat Jul 16 13:02:38 2022 +0300

    style code fixes pt. 3

commit ed86610
Author: Antti Peisa <[email protected]>
Date:   Sat Jul 16 12:55:21 2022 +0300

    make the stringable object type safe

commit 50221ef
Author: Antti Peisa <[email protected]>
Date:   Sat Jul 16 12:53:31 2022 +0300

    style code fixes pt. 2

commit 496f8a0
Author: Antti Peisa <[email protected]>
Date:   Sat Jul 16 12:52:29 2022 +0300

    style code fixes

commit f6c9678
Author: Antti Peisa <[email protected]>
Date:   Sat Jul 16 12:50:09 2022 +0300

    support stringable objects when sorting

commit ad4422a
Merge: f4c448f fc67e04
Author: Stas <[email protected]>
Date:   Wed Jun 29 22:04:13 2022 +0300

    Merge pull request #2365 from jenssegers/update-changelog

    chore: update changelog and prepare release

commit 5d292a2
Author: Pavel Borunov <[email protected]>
Date:   Sat May 28 09:57:03 2022 +0300

    Respect new Laravel accessors's approach

    Fix getting a value from a one-word `\Illuminate\Database\Eloquent\Casts\Attribute`-returning accessors

commit fc67e04
Author: divine <[email protected]>
Date:   Fri Mar 11 04:14:08 2022 +0300

    chore: update changelog and prepare release

commit f4c448f
Author: Divine <[email protected]>
Date:   Mon Mar 7 23:07:22 2022 +0300

    feat: backport support for cursor pagination (#2362)

    Backport #2358 to L9

    Co-Authored-By: Jeroen van de Weerd <[email protected]>

commit 8d601b2
Author: Rob Brain <[email protected]>
Date:   Wed Mar 2 03:45:43 2022 +0700

    Check if failed log storage is disabled in Queue Service Provider (#2357)

    * fix: check if failed log storage is disabled in Queue Service Provider

    Co-authored-by: divine <[email protected]>

commit 1e49c5e
Merge: 6cdd309 b6a76f9
Author: Jens Segers <[email protected]>
Date:   Thu Feb 17 11:00:31 2022 +0100

    Merge pull request #2344 from divine/l9

    feat: initial laravel 9 compatibility

commit b6a76f9
Author: divine <[email protected]>
Date:   Wed Feb 9 05:03:48 2022 +0300

    fix: apply php-cs-fixer result

commit 20b9d0e
Author: divine <[email protected]>
Date:   Wed Feb 9 04:30:38 2022 +0300

    fix: small php-doc comment

commit 8b4c6dc
Author: divine <[email protected]>
Date:   Wed Feb 9 04:26:20 2022 +0300

    fix: apply php-cs-fixer results

commit 40846ab
Author: divine <[email protected]>
Date:   Wed Feb 9 04:22:39 2022 +0300

    fix: imrprove php-doc comments

commit 42c1ff2
Author: divine <[email protected]>
Date:   Wed Feb 9 04:04:43 2022 +0300

    feat: update php-cs-fixer & docker php version

commit 9c2b001
Author: divine <[email protected]>
Date:   Wed Feb 9 03:59:33 2022 +0300

    feat: use stable laravel release

commit d02a46c
Author: divine <[email protected]>
Date:   Sun Feb 6 05:40:20 2022 +0300

    feat: initial laravel 9 compatibility

commit 6cdd309
Merge: 6aa6ad1 39f940d
Author: Stas <[email protected]>
Date:   Wed Feb 2 02:35:36 2022 +0300

    Merge pull request #2341 from divine/update-changelog

    [3.8] Update changelog

commit 39f940d
Author: divine <[email protected]>
Date:   Tue Feb 1 03:43:56 2022 +0300

    chore: add missing dots to readme.

commit 2322a78
Author: divine <[email protected]>
Date:   Tue Feb 1 03:42:44 2022 +0300

    chore: update changelog
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert @Jeroenwv
feat: backport support for cursor pagination (mongodb#2362)
c3e4a1e 
Backport mongodb#2358 to L9

Co-Authored-By: Jeroen van de Weerd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smolevich Smolevich Smolevich approved these changes

@jenssegers jenssegers Awaiting requested review from jenssegers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

does not support cursorPaginate method
3 participants
@divine @codecov-commenter @Smolevich