-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doesntExist to passthru #2194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
There are other missing passthru functions. See #1765
Could you please kindly add missing ones from https://github.com/illuminate/database/blob/8.x/Eloquent/Builder.php#L81-L84 to make it consistent?
I have prepared my own PR for this a few months back but it was delayed as we didn't decide how to test this at all between versions.
Thanks!
Hello @simonschaufi, Do you plan to complete this PR or should I close and push on my own? Thanks! |
@divine you can make adjustments on my branch actually. I'm traveling at the moment and could finish it in April |
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
=========================================
Coverage 86.93% 86.93%
Complexity 663 663
=========================================
Files 33 33
Lines 1554 1554
=========================================
Hits 1351 1351
Misses 203 203
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
=========================================
Coverage 86.93% 86.93%
Complexity 663 663
=========================================
Files 33 33
Lines 1554 1554
=========================================
Hits 1351 1351
Misses 203 203
Continue to review full report at Codecov.
|
@divine Thanx! Is there anything still to do for me or will you merge it? |
Hello @simonschaufi , We will merge it tomorrow, just waiting for @Smolevich review just in case. The last push was to fix the link of related PR and nothing is left. Thanks! |
Awesome! |
@divine @Smolevich can this also be backported into older releases? that would be great! |
If you can take care of it, why not 😁. Thanks! |
Anyways, I might take care of it at the weekend if you're busy @simonschaufi . Thanks! |
Add doesntExist to passthru
Those calls should return the same result but instead the call to "doesntExist" returns an object.
closes #1765