Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectId's PROCESS_UNIQUE lazy loaded #435

Merged

Conversation

steffenagger
Copy link
Contributor

Description

This PR changes PROCESS_UNIQUE in the ObjectId class to be lazy loaded. The main reason is allow for the randomBytes fallback-warning to only trigger if/when utilized.

I also took the liberty to remove som unused variables.

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristianoccazinsp
Copy link

Looking forward for this to be released as the warning is wrecking havoc in our error reporting tool :(

@durran durran merged commit 2aba3c0 into mongodb:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants