fix: improve ArrayBuffer brand check in ensureBuffer #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`instanceof` is notoriously unreliable in JS, because it can be fooled by prototype manipulation and breaks down entirely for cross-realm brand checks. Using `Object.prototype.toString` is generally a better choice for this. This also adds `SharedArrayBuffer` as an alternative, as both should be treated the same under most circumstances.
addaleax
force-pushed
the
better-buffer-typecheck
branch
from
e476412 to
e53e6a7
Compare
durran
approved these changes
Apr 8, 2021
emadum
approved these changes
Apr 9, 2021
nbbeeken
approved these changes
Apr 9, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
instanceofis notoriously unreliable in JS, because it canbe fooled by prototype manipulation and breaks down entirely
for cross-realm brand checks.
Using
Object.prototype.toStringis generally a better choicefor this.
This also adds
SharedArrayBufferas an alternative, as bothshould be treated the same under most circumstances.