Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert to Typescript (#388) #393

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

nbbeeken
Copy link
Contributor

Just for a sanity check this is the commit message that this merge should have:

refactor: Convert to Typescript (#388)

This is the first stage of converting the entire codebase over to
TypeScript. The goals of this step were to preserve history as
well as functional output of the compilation step. Here is a
summary of the commits involved:

 - move all files to `src`, preserving history
   this also maintains a copy of the original js source in the `lib`
   folder (without history) so we can compare the transpiled output
   for potential issues
 - add type information to all types
 - move entry point `bson.ts` to `src` folder for ease of future testing
 - run tests against transpiled module code
 - fix all linting issues with ts conversion
 - fix running manual tests with ts codebase
 - ensure we run the ts pipeline before publish
 - bump typescript version, fix last outstanding issue
 - `prepublishOnly` => `prepare`

NODE-2716, NODE-2718, NODE-2719, NODE-2721

@nbbeeken nbbeeken requested a review from mbroadst September 14, 2020 15:08
@mbroadst mbroadst merged commit 9aad874 into master Sep 14, 2020
@mbroadst mbroadst deleted the revert-390-revert-388-NODE-2716/ts-bson branch September 14, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants