Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-227413: AKO templates #348
CLOUDP-227413: AKO templates #348
Changes from 9 commits
74b1c67
42993b4
8114637
297adab
c8ed866
bb225b7
2e8cee2
785203d
56eaa33
d0cfd8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think my question still applies: how do we make sure that this does not introduce skew when we move forward with new AKO versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the helm chart version does not need to match the version of the image.
These examples are even less tied to the Operator releases, they should just keep working after most releases, unless some breaking changes are released.
I see two ways about this:
If we do not automate on auto testing these, we will be forced to option 1, at least until we make such investment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to the latest AKO version just in case. As we do the same thing for the AKO chart and the AKO CRDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With respect to the
appVersion
field: https://helm.sh/docs/topics/charts/#the-appversion-fieldWith respect to the
version
field: https://helm.sh/docs/topics/charts/#charts-and-versioningMy conclusions from the above are the following:
Given
appVersion
is purely informational I vote for making it clear (as a comment) that this is the version of AKO this helm was created with.Given
version
is a semver version of this chart specifically I vote to set it to "1.0" since this is the very first version of this chart@josvazg @igor-karpukhin thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.
Also I would avoid having to re-release this with all released of AKO. Releasing only when new versions might force it due to breaking changes or features than need to be showcased.