Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-218697: Fix get latest tag #299

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 3, 2024

The bash function get_latest_tag was failing in some cases, detecting older tags as the latest.

This fix changes the way the latest tag is computed so we always get correct results.

Release charts dryrun detects NO skews between latest released chart and latest tag

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg force-pushed the CLOUDP-218697/fix-get-latest-tag branch from 7b309a3 to 0452363 Compare January 3, 2024 09:37
@josvazg
Copy link
Collaborator Author

josvazg commented Jan 3, 2024

See for example:
https://github.com/mongodb/helm-charts/actions/runs/7394981709/job/20117479890

released result: "mongodb/mongodb-atlas-operator     	2.0.1        	2.0.1      	MongoDB Atlas Operator - a Helm chart for insta..."
Looking for versions...
version from tag: 1.9.2
version from chart: 2.0.1
...
released result: "mongodb/community-operator     	0.9.0        	0.9.0      	MongoDB Kubernetes Community Operator       "
Looking for versions...
version from tag: 0.8.3
version from chart: 0.9.0

This provoked errors as it tried to re-release versions already released.

Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit 43e188c into main Jan 3, 2024
1 check passed
@josvazg josvazg deleted the CLOUDP-218697/fix-get-latest-tag branch January 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants