CLOUDP-218696: Check chart was actually released #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
irajdeep,
tibulca,
mircea-cosbuc,
igor-karpukhin,
helderjs,
lsierant,
slaskawi,
roothorp and
nammn
as code owners
s-urbaniak
approved these changes
Dec 19, 2023
josvazg
force-pushed
the
CLOUDP-218696/fix-releases
branch
3 times, most recently
from
edc6de0
to
75020d3
Compare
Signed-off-by: Jose Vazquez <[email protected]>
josvazg
force-pushed
the
CLOUDP-218696/fix-releases
branch
from
75020d3
to
b941433
Compare
helderjs
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior logic was checking git tags, which did not seem reliable at times and checks the wrong thing: we do not care as much for the tag to be present in git as for the actual helm chart with the given version to be present in the target helm chart repo.
This change searchs the repo for the expected chart version to check whether it was released or not, before checkign for changes in the chart.
✅ DRYRUN did not find anything to do after release
All Submissions: