Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-781: Query Parameter Add: retainBackups in Cluster and Advanced_Cluster #493

Merged
merged 3 commits into from
Jun 7, 2023
Merged

INTMDB-781: Query Parameter Add: retainBackups in Cluster and Advanced_Cluster #493

merged 3 commits into from
Jun 7, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 6, 2023 •
edited
Loading

Description

This PR adds support for the query param retainBackups in cluster and advance cluster

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo added the breaking Pull requests that breaks backwards compatibility label Jun 6, 2023
@andreaangiolillo andreaangiolillo requested a review from gssbzn June 6, 2023 09:41
@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 6, 2023 09:41
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 6, 2023 09:41
@andreaangiolillo andreaangiolillo requested review from gssbzn and a team June 6, 2023 12:14
gssbzn
gssbzn approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit c3435ec into master Jun 7, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-781 branch June 7, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn