Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-179698 Add tags to clusters #488

Merged
merged 2 commits into from
May 29, 2023
Merged

CLOUDP-179698 Add tags to clusters #488

merged 2 commits into from
May 29, 2023

Conversation

fmenezes
Copy link
Contributor

@fmenezes fmenezes commented May 29, 2023 •
edited
Loading

Description

Adding tags to the clusters APIs.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Context, we are changing this here given clusters is still being changed to SDKv2, so while it stays on SDKv1 we have to make this change here.

@fmenezes fmenezes marked this pull request as ready for review May 29, 2023 09:51
@fmenezes fmenezes requested a review from a team as a code owner May 29, 2023 09:51
wtrocki
wtrocki approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on having this in the manual sdk as it unblocks the team and gives us time to swap.

@fmenezes fmenezes merged commit eb219ee into master May 29, 2023
@fmenezes fmenezes deleted the CLOUDP-179698 branch May 29, 2023 09:54
@fmenezes fmenezes mentioned this pull request May 29, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmenezes @wtrocki