Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-804: struct fixes #483

Merged
merged 2 commits into from
May 18, 2023
Merged

INTMDB-804: struct fixes #483

merged 2 commits into from
May 18, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented May 17, 2023 •
edited
Loading

Description

This PR is a follow-up of #482. Making some fixes after testing the resource with terraform

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review May 18, 2023 14:57
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner May 18, 2023 14:57
gssbzn
gssbzn approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but does any of the fixes here require fixes on the OpenAPI spec?

@andreaangiolillo
Copy link
Collaborator Author

but does any of the fixes here require fixes on the OpenAPI spec?

No, the open API spec is correct. These errors are because of me :/

@andreaangiolillo andreaangiolillo merged commit fd538db into master May 18, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-804_fix branch May 18, 2023 15:35
@gssbzn
Copy link
Collaborator

gssbzn commented May 18, 2023

No harm done just double checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn