Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-587: New Feature: Backup Compliance Policy Support #453

Merged
merged 7 commits into from
Apr 14, 2023
Merged

INTMDB-587: New Feature: Backup Compliance Policy Support #453

merged 7 commits into from
Apr 14, 2023

Conversation

martinstibbe
Copy link
Collaborator

@martinstibbe martinstibbe commented Apr 14, 2023 •
edited
Loading

Description

New Feature: Backup Compliance Policy Support

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner April 14, 2023 02:09
andreaangiolillo
andreaangiolillo previously approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really small suggestions that are not blocking. LGTM

mongodbatlas/backup_compliance_policy.go Show resolved Hide resolved
mongodbatlas/backup_compliance_policy.go Outdated Show resolved Hide resolved
mongodbatlas/backup_compliance_policy_test.go Outdated Show resolved Hide resolved
@andreaangiolillo
Copy link
Collaborator

@martinstibbe Lint is failing

andreaangiolillo
andreaangiolillo approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstibbe martinstibbe merged commit 0fca1fa into master Apr 14, 2023
@martinstibbe martinstibbe deleted the INTMDB-587 branch April 14, 2023 20:25
@maastha maastha mentioned this pull request Apr 17, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinstibbe @andreaangiolillo