Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-648: Add CollectionType support #432

Merged
merged 1 commit into from
Mar 27, 2023
Merged

INTMDB-648: Add CollectionType support #432

merged 1 commit into from
Mar 27, 2023

Conversation

martinstibbe
Copy link
Collaborator

@martinstibbe martinstibbe commented Mar 24, 2023 •
edited
Loading

Description

Add CollectionType support to online archive

Link to any related issue(s):
mongodb/terraform-provider-mongodbatlas#1081

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner March 24, 2023 18:06
@wtrocki
Copy link
Member

wtrocki commented Mar 27, 2023

@martinstibbe you can make terraform use that branch using go get:

▶ go get go.mongodb.org/atlas@INTMDB-648

@colm-quinn colm-quinn merged commit 333af23 into master Mar 27, 2023
@colm-quinn colm-quinn deleted the INTMDB-648 branch March 27, 2023 15:43
@andreaangiolillo andreaangiolillo mentioned this pull request Mar 27, 2023
Merged
8 tasks
Zuhairahmed
Zuhairahmed reviewed Mar 27, 2023
View reviewed changes
mongodbatlas/online_archives_test.go
client, mux, teardown := setup()
defer teardown()

groupID := "5e2211c17a3e5a48f5497de3"
Copy link

@Zuhairahmed Zuhairahmed Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be hardcoding project IDs here?

Copy link

@Zuhairahmed Zuhairahmed Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Martin confirm this is dummy variable for local test harness (3/27/23)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed left review comments

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinstibbe @wtrocki @Zuhairahmed @colm-quinn