Add global cluster support for advanced cluster #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sugar-pack
changed the title
This was referenced Dec 28, 2022
mongodbatlas/global_clusters_test.go
Outdated
| @@ -31,7 +31,7 @@ func TestGlobalClusters_Get(t *testing.T) { | |||
| groupID := "1" | |||
| clusterName := "appData" | |||
|
|
|||
| mux.HandleFunc(fmt.Sprintf("/api/atlas/v1.0/groups/%s/clusters/%s/globalWrites", groupID, clusterName), func(w http.ResponseWriter, r *http.Request) { | |||
| mux.HandleFunc(fmt.Sprintf("/api/atlas/v1.5/groups/%s/clusters/%s/globalWrites", groupID, clusterName), func(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
One question, not to @Sugar-pack probably. This path is quite similar to the one defined by the globalClustersBasePath constant. Maybe it would be better to use this constant here and in other places.
There was a problem hiding this comment.
Sugar-pack
force-pushed
the
update_global_cluster
branch
from
8828896 to
5c15a70
Compare
Sugar-pack
force-pushed
the
update_global_cluster
branch
from
5c15a70 to
6b2fc93
Compare
|
@AndreiMatei2206 could you please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the API version for the global cluster (add support for advanced cluster).
Update managed namespace struct (full compatibility with API)
Link to any related issue(s):
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments