Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-114669: Automatically add trailing slash to the URL #281

Merged

Conversation

igor-karpukhin
Copy link
Contributor

Description

This PR adds an ability for the Client to automatically add trailing slash (/) to the end of the provided URL. The motivation behind this is that some internal tools use this library and it is easier to assume that the library handles both cases: with, and without trailing slash.

cc: @jamesbroadhead

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-114669

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@igor-karpukhin igor-karpukhin requested a review from a team as a code owner March 7, 2022 19:00
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-karpukhin
Copy link
Contributor Author

igor-karpukhin commented Mar 14, 2022

@andreaangiolillo thanks for approving this PR. Could you please approve CI/CD workflow if you have one? Merge is not possible atm.

gssbzn
gssbzn previously requested changes Mar 14, 2022
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this we nened this chnages on the ops manager client

@gssbzn
Copy link
Collaborator

gssbzn commented Mar 14, 2022

We keep atlas and ops manager compatible so we need this same change for https://github.com/mongodb/go-client-mongodb-ops-manager

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 14, 2022 14:56
@andreaangiolillo andreaangiolillo dismissed gssbzn’s stale review March 14, 2022 15:25

The same change has been merged in the ops manager go client

@andreaangiolillo andreaangiolillo merged commit 116acf9 into mongodb:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants