Update Makefile #6190
Closed
Update Makefile #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdestefano-mongo
requested changes
Feb 8, 2022
There was a problem hiding this comment.
@GuruPKK Thanks for the PR, requesting some changes. Cheers
Makefile
Outdated
| @@ -5,6 +5,16 @@ PRODUCTION_URL="https://docs.mongodb.com" | |||
| STAGING_BUCKET=docs-mongodb-org-stg | |||
| PRODUCTION_BUCKET=docs-mongodb-org-prd | |||
|
|
|||
| ifeq ($(ENV), 'dotcom_stg') | |||
There was a problem hiding this comment.
Do you think we should avoid calling this "ENV" to avoid conflict with the unix env command? Maybe something like docsenv or publishenv?
Makefile
Outdated
| STAGING_BUCKET=docs-mongodb-org-dotcomstg | ||
| endif | ||
|
|
||
| ifeq ($(ENV), 'dotcom_prd') |
There was a problem hiding this comment.
Writers will want to stage and publish to the same environment. Let's have one variable check for "dotcom" and set both the staging and prod URLs/buckets in one shot.
Makefile
Outdated
| @@ -5,6 +5,16 @@ PRODUCTION_URL="https://docs.mongodb.com" | |||
| STAGING_BUCKET=docs-mongodb-org-stg | |||
| PRODUCTION_BUCKET=docs-mongodb-org-prd | |||
|
|
|||
| ifeq ($(ENV), 'dotcom_stg') | |||
| STAGING_URL="https://docs-mongodborg-staging.corp.mongodb.com" | |||
There was a problem hiding this comment.
Per discussion staging URL needs to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.