Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsp 45182 ruby databases collection 2 #117

Conversation

gmiller-mdb
Copy link

@gmiller-mdb gmiller-mdb commented Jan 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45182

Staging Links

  • databases-collection
  • index
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Jan 3, 2025

    Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit a0e0b95
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/6786a9ed4700fb0008a6e572
    😎 Deploy Preview https://deploy-preview-117--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @gmiller-mdb
    Copy link
    Author

    I am trying to add the {+api+} links but after trying a variety of different formats (as evidenced) I cannot find the right URL combination.

    @gmiller-mdb
    Copy link
    Author

    just tested adding bundler code/a separate page for the code examples. I am not sure why new pages I created for another standardization page (and in a completely different branch) got added- will delete them later.

    @norareidy norareidy changed the base branch from master to standardization January 6, 2025 21:43
    Copy link
    Contributor

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A few changes please!

    source/databases-collection.txt Outdated Show resolved Hide resolved
    source/databases-collection.txt Outdated Show resolved Hide resolved
    source/databases-collection.txt Show resolved Hide resolved
    Comment on lines 92 to 93
    create command. For a full list of optional parameters, refer to the MongoDB
    documentation on creating collections.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I couldn't find the documentation specifically about creating collections, only the create command, which I think you should reference here:

    Suggested change
    create command. For a full list of optional parameters, refer to the MongoDB
    documentation on creating collections.
    create command. For a full list of optional parameters, refer to the MongoDB
    documentation on the :manual:`create command/reference/command/create/`.

    Double check that link, it should link here: https://www.mongodb.com/docs/manual/reference/command/create/

    Copy link
    Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    link did not work for me, I just put in a regular reference link

    source/databases-collection.txt Outdated Show resolved Hide resolved
    Copy link
    Contributor

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Link formatting:

    source/databases-collection.txt Outdated Show resolved Hide resolved
    @rachel-mack rachel-mack self-requested a review January 7, 2025 18:18
    Copy link
    Contributor

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @gmiller-mdb gmiller-mdb requested a review from jamis January 7, 2025 19:54
    @comandeo-mongo
    Copy link
    Contributor

    I cannot find the new page on the preview deployment - https://deploy-preview-117--docs-ruby.netlify.app/ Am I just missing it or is it intentional?

    source/databases-collection.txt Outdated Show resolved Hide resolved
    source/databases-collection.txt Outdated Show resolved Hide resolved
    source/read/databases-collection.rb Outdated Show resolved Hide resolved
    source/read/databases-collection.rb Outdated Show resolved Hide resolved
    source/read/databases-collection.rb Outdated Show resolved Hide resolved
    @gmiller-mdb gmiller-mdb requested a review from jamis January 13, 2025 17:48
    @gmiller-mdb gmiller-mdb merged commit 1a70647 into mongodb:standardization Jan 14, 2025
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants