Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-16785 the the typo #3297

Conversation

osharaf-mdb
Copy link
Contributor

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-16785

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • programming_language
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-realm work, if any

Release Notes

  • Across many docs-realm pages
    • fixed "the the" typo and added meta data

Review Guidelines

REVIEWING.md

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the the's look good, thanks!

For the meta descriptions, you'll want to replace Atlas App Services with "Atlas Device SDK". App Services is actually a separate product from the SDKs which are documented here (we'll do a talk on App Services the week after next)! When using the term "realm", I would use the full term "realm database" to specify as well.

For more context, "Realm" is now the name of just the database as we changed the name of the SDKs from Realm SDKs to "Atlas Device SDKs". Here is a link to how we refer to SDKs of different languages after the name change. The cheatsheet at the bottom is especially helpful!: https://docs.google.com/document/d/126OczVxBWAwZ4P5ZsSM29WI3REvONEr1ald-mAwPtyQ/edit#heading=h.lwkbqtp71sr5

You can used the meta descriptions I fixed as examples or templates. Try to fix the remaining ones, and I'll take another look, thanks!

temp/dotnet/app-services/call-a-function.txt Outdated Show resolved Hide resolved
temp/cpp/users/custom-user-data.txt Outdated Show resolved Hide resolved
temp/dotnet/app-services/call-a-function.txt Outdated Show resolved Hide resolved
temp/dotnet/manage-users/custom-user-data.txt Outdated Show resolved Hide resolved
temp/flutter/sync/write-to-synced-realm.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Added 'the' in front of Atlas Device SDK to standardize the copy, as that seems to be how we use it when indicating a specific language.

temp/cpp/users/custom-user-data.txt Outdated Show resolved Hide resolved
temp/flutter/users/custom-user-data.txt Outdated Show resolved Hide resolved
temp/kotlin/users/custom-user-data.txt Outdated Show resolved Hide resolved
temp/node/users/authenticate-users.txt Outdated Show resolved Hide resolved
temp/swift/swiftui/swiftui-previews.txt Outdated Show resolved Hide resolved
temp/swift/sync/write-to-synced-realm.txt Outdated Show resolved Hide resolved
temp/swift/users/custom-user-data.txt Outdated Show resolved Hide resolved
@osharaf-mdb osharaf-mdb reopened this Jun 25, 2024
@osharaf-mdb osharaf-mdb merged commit 451b40f into mongodb:feature-consolidated-sdk-docs Jun 25, 2024
5 of 7 checks passed
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants