-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-16785 the the typo #3297
DOCSP-16785 the the typo #3297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the the's look good, thanks!
For the meta descriptions, you'll want to replace Atlas App Services with "Atlas Device SDK". App Services is actually a separate product from the SDKs which are documented here (we'll do a talk on App Services the week after next)! When using the term "realm", I would use the full term "realm database" to specify as well.
For more context, "Realm" is now the name of just the database as we changed the name of the SDKs from Realm SDKs to "Atlas Device SDKs". Here is a link to how we refer to SDKs of different languages after the name change. The cheatsheet at the bottom is especially helpful!: https://docs.google.com/document/d/126OczVxBWAwZ4P5ZsSM29WI3REvONEr1ald-mAwPtyQ/edit#heading=h.lwkbqtp71sr5
You can used the meta descriptions I fixed as examples or templates. Try to fix the remaining ones, and I'll take another look, thanks!
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: cbullinger <[email protected]>
Co-authored-by: cbullinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Added 'the' in front of Atlas Device SDK to standardize the copy, as that seems to be how we use it when indicating a specific language.
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
451b40f
into
mongodb:feature-consolidated-sdk-docs
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/feature-consolidated-sdk-docs/ 🪵 Logs |
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-16785
Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Review Guidelines
REVIEWING.md