Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in Cargo.lock.msrv #436

Merged
merged 1 commit into from
Oct 25, 2023
Merged

RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in Cargo.lock.msrv #436

merged 1 commit into from
Oct 25, 2023

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Oct 24, 2023 •
edited
Loading

ahash 0.8.3 and older were yanked because of a security vulnerability, and 0.8.4 (with a bug) and 0.8.5 were released to address that. ahash 0.8.5 requires Rust 1.61+. As a result, the Evergreen task for mongo-rust-driver that checks MSRV compilation started to fail.

mongodb/mongo-rust-driver#981 is the corresponding PR in mongo-rust-driver.

RUST-1780

@stIncMale
RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in `Cargo.loc…
b8141e4 
…k.msrv`

`ahash` 0.8.3 and older were yanked because of a security vulnerability,
and 0.8.4 (with a bug) and 0.8.5 were released to address that.
`ahash` 0.8.5 requires Rust 1.61+. As a result, the Evergreen task for
`mongo-rust-driver` that checks MSRV compilation started to fail.
@stIncMale
Copy link
Member Author

According to README.md, the MSRV can only be changed in a minor or major release. Should the bson-rust version be updated to 2.8.0 in this PR, or do you usually update it separately?

@stIncMale stIncMale mentioned this pull request Oct 24, 2023
Merged
@abr-egn
Copy link
Contributor

abr-egn commented Oct 24, 2023

According to README.md, the MSRV can only be changed in a minor or major release. Should the bson-rust version be updated to 2.8.0 in this PR, or do you usually update it separately?

Nope, just make sure to tag RUST-1780 with the 2.8.0 fix version so we include the MSRV being bumped in the release notes for that.

abr-egn
abr-egn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stIncMale
Copy link
Member Author

stIncMale commented Oct 24, 2023 •
edited
Loading

tag RUST-1780 with the 2.8.0 fix version

@abr-egn Should I also create bson-2.8.0, so that RUST-1780 is tagged with both 2.8.0 and bson-2.8.0? I also noticed that there is bson-3.0.0, and there are already tickets tagged with it.

@abr-egn
Copy link
Contributor

abr-egn commented Oct 24, 2023

Should I also create bson-2.8.0, so that RUST-1780 is tagged with both 2.8.0 and bson-2.8.0? I also noticed that there is bson-3.0.0, and there are already tickets tagged with it.

Oh, yup, tagging with bson-2.8.0 would be good. We only tag tickets for 3.0.0 or bson-3.0.0 if they would be breaking changes, it's a convenient way to keep track of what needs to be done when we decide it's time for a major version release.

@abr-egn abr-egn merged commit a73ee9d into mongodb:main Oct 25, 2023
7 checks passed
@stIncMale stIncMale deleted the RUST-1780 branch October 25, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelatkinson isabelatkinson isabelatkinson approved these changes

@abr-egn abr-egn abr-egn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stIncMale @abr-egn @isabelatkinson