RUST-960 Deprecate decimal128 feature flag (1.2.x)
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Aug 4, 2021
| @@ -23,6 +27,8 @@ pub struct Decimal128 { | |||
| } | |||
|
|
|||
| #[cfg(feature = "decimal128")] | |||
| #[deprecated = "The feature-gated decimal128 implementation serializes to BSON incorrectly and \ | |||
| should not be used. It will be removed completely in 2.0.0"] | |||
| impl Decimal128 { | |||
There was a problem hiding this comment.
To only deprecate the feature-flag and not the Decimal128 struct itself, I only added the attribute to this impl block.
isabelatkinson
approved these changes
Aug 4, 2021
abr-egn
approved these changes
Aug 4, 2021
NBSquare
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-960
This PR deprecates the
decimal128feature flag due to the reasons highlighted in #282.semver requires that deprecations happen in minor rather than patch versions, but
decimal128being "unstable and experimental" means it isn't really bound by semver, so I think we're okay to do this in a patch release. Thoughts?