RUST-880 Fix crash when deserializing/serializing Document that contains decimal128
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Aug 2, 2021
| #[cfg(not(feature = "decimal128"))] | ||
| Bson::Decimal128(ref v) => { | ||
| doc! { | ||
| "$numberDecimalBytes": Bson::Binary(Binary { |
There was a problem hiding this comment.
This format matches what we went for on master.
abr-egn
approved these changes
Aug 2, 2021
isabelatkinson
approved these changes
Aug 3, 2021
NBSquare
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-880
This PR fixes a crash that occurs in
1.2.xwhen deserializing from or serializing to aDocumentthat contains a decimal128 when thedecimal128feature flag is not enabled. Note that this has already been fixed on master.This PR also fixes the clippy failures that started since the latest Rust release.