Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CLOUDP-215956 - Convert our bug report issue on GitHub to forms #182

Merged
merged 11 commits into from
Dec 20, 2023
Merged

chore: CLOUDP-215956 - Convert our bug report issue on GitHub to forms #182

merged 11 commits into from
Dec 20, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Dec 19, 2023 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-215956

Same PR for TF mongodb/terraform-provider-mongodbatlas#1767

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner December 19, 2023 17:27
@andreaangiolillo andreaangiolillo marked this pull request as draft December 19, 2023 17:27
@andreaangiolillo andreaangiolillo marked this pull request as ready for review December 19, 2023 18:15
lantoli
lantoli previously approved these changes Dec 19, 2023
View reviewed changes
@andreaangiolillo andreaangiolillo requested review from lantoli and a team December 19, 2023 18:20
lantoli
lantoli reviewed Dec 19, 2023
View reviewed changes
API.md Show resolved Hide resolved
@andreaangiolillo andreaangiolillo merged commit 77a188a into main Dec 20, 2023
11 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-215956 branch December 20, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @lantoli