Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Upate bson to use released version #35

Closed
wants to merge 1 commit into from

Conversation

nevi-me
Copy link
Contributor

@nevi-me nevi-me commented Feb 22, 2020

Bson has added decimal support and this crate can use it.

Checklist

  • [-] tests pass (not all tests pass, failures are referencing file(s) which aren't in the repo)
  • tests and/or benchmarks are included
  • documentation is changed or added

Context

The bson crate was pinned to a branch on a fork of rust-bson. This fork has fallen behind, and my PR is updating to the released bson crate.

Semver Changes

None

Bson has added decimal support and this crate can use it.
@lrlna
Copy link
Member

lrlna commented Feb 23, 2020

I am not able to have the most recent version since it doesn't have a wasm compiling Decimal128 implementation. If I remember correctly, bson-rust crate will have it in relatively soon, the team is just working on getting async stuff in first.

@nevi-me
Copy link
Contributor Author

nevi-me commented Feb 23, 2020

Ah, that makes sense. Though it might not help, would you be open to feature-gating the wasm support? I'm exploring writing a mongo connector for a dataframe crate I'm writing, so schema inference becomes important. In the short term I could do without the inference, but if what I'm building becomes useful to people, that need would arise.

@nevi-me nevi-me closed this Feb 24, 2020
@lrlna
Copy link
Member

lrlna commented Feb 24, 2020

Hmmm, I think we should be okay putting wasm under a feature flag. Let me try and play around with the cargo toml and see if I can get everything to compile properly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants