Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(copilot): export to Language with Copilot VSCODE-573 #870

Merged
merged 16 commits into from
Nov 21, 2024
Merged

feat(copilot): export to Language with Copilot VSCODE-573 #870

merged 16 commits into from
Nov 21, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Nov 8, 2024 •
edited
Loading

Description

  • Export to language from a playground (Shell) to a target language using the VSCode Copilot model.
  • Use only the Include/exclude driver syntax code lenses.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika marked this pull request as ready for review November 11, 2024 14:24
Anemy
Anemy reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a couple small suggestions/questions. I'll give this a run tomorrow

src/editors/playgroundSelectionCodeActionProvider.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/participant/prompts/exportToLanguage.ts Show resolved Hide resolved
src/telemetry/telemetryService.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
Anemy
Anemy approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Left a few questions/suggestions and user experience suggestions.

src/editors/playgroundSelectionCodeActionProvider.ts Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/mdbExtensionController.ts Outdated Show resolved Hide resolved
Anemy
Anemy reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, noticed 2 smaller things we probably want to change, and left one question.

src/editors/exportToLanguageCodeLensProvider.ts Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/editors/playgroundSelectionCodeActionProvider.ts Show resolved Hide resolved
Anemy
Anemy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice

@alenakhineika alenakhineika merged commit 50c385f into main Nov 21, 2024
6 checks passed
@alenakhineika alenakhineika deleted the VSCODE-573-export-to-language-copilot branch November 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @Anemy