Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chat): Report response telemetry VSCODE-603 #845

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

nirinchev
Copy link
Contributor

@nirinchev nirinchev commented Sep 27, 2024

Description

Final bit from VSCODE-575. This doesn't follow exactly the design as I wasn't sure how we can track round_trips_number. If we decide to drop this requirement, we should update ParticipantResponseProperties.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Base automatically changed from ni/prompt-telemetry to VSCODE-528-mongodb-copilot September 27, 2024 21:05
@nirinchev nirinchev force-pushed the ni/response-telemetry branch from 461d5da to eca84dd Compare September 27, 2024 21:06
@nirinchev nirinchev requested a review from Anemy September 27, 2024 21:07
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple questions on event types and when we report them

src/participant/participant.ts Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/telemetry/telemetryService.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Show resolved Hide resolved
src/participant/participant.ts Show resolved Hide resolved
@Anemy Anemy merged commit 36a6784 into VSCODE-528-mongodb-copilot Sep 27, 2024
3 checks passed
@Anemy Anemy deleted the ni/response-telemetry branch September 27, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants