fix(chat): avoid passing file path when its not used in playground run VSCODE-625 #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Sep 27, 2024
| const shouldConfirmRunCopilotCode = vscode.workspace | ||
| .getConfiguration('mdb') | ||
| .get('confirmRunCopilotCode'); | ||
|
|
||
| if (!this._connectionController.isCurrentlyConnected()) { | ||
| // TODO(VSCODE-618): Prompt user to connect when clicked. | ||
| void vscode.window.showErrorMessage(connectBeforeRunningMessage); |
There was a problem hiding this comment.
Another drive-by, adding an error message when trying to run when not connected, and a todo for the changes in VSCODE-618.
alenakhineika
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-625
Did a bit of drive by renaming
query->code. There's a good amount of code we could cleanup in the playground controller around running playgrounds, however I'm going to avoid doing any more changes there as we want to code freeze and a lot of them are already done in Alena's pr on exporting code to playground.