Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(participant): export to a playground VSCODE-574 #832
feat(participant): export to a playground VSCODE-574 #832
Changes from 9 commits
7a456b4
ebe0b8d
f23eb4a
da0cd94
e2692de
c897181
ba5fdb6
94d88c0
55d634e
49f330a
ea05667
5d873df
b6c30eb
1eb6bf5
52d66b5
05ea3c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 65 in src/editors/playgroundController.ts
GitHub Actions / Test and Build (ubuntu-latest)
Check warning on line 65 in src/editors/playgroundController.ts
GitHub Actions / Test and Build (macos-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're already passing the cancellation token to
getChatResponseContent
- why do we need the extra promise here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem that the token passed to the
await model.sendRequest(messages, {}, token)
terminates the request to the model and the model returns a result anyway. I want to investigate this more separately and maybe file the ticket to vscode.